-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the entries shown by default #1036
Comments
As I mentioned in my reply there, sometimes those single kanji entries are useful, e.g. when looking up 非の打ち所がない That said, now that the popup should be scrollable on all devices, perhaps we could define an "above the fold" cut-off so that you need to scroll to see the remaining entries based on some heuristic like only showing the longest matches (or any substring matches that are still significantly long). Doing this might also allow us to actually return more results as requested in #555. We might also filter out some results like single-kanji results that only match on reading (not on kanji) so that, for example, we don't show the entry for 血 just because you looked up a word that started with a kana ち/チ. Given that I've never heard anyone complain about this before, it might be best to make any change in behavior here able to be disabled with a setting. |
As per this review: https://addons.mozilla.org/en-US/firefox/addon/10ten-ja-reader/reviews/1905937/
Copying the full text here for posterity:
The text was updated successfully, but these errors were encountered: