Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up misplacement in webpages with frameset elements #1241

Closed
SaltfishAmi opened this issue Jul 15, 2023 · 3 comments · Fixed by #1290
Closed

Pop-up misplacement in webpages with frameset elements #1241

SaltfishAmi opened this issue Jul 15, 2023 · 3 comments · Fixed by #1290

Comments

@SaltfishAmi
Copy link
Contributor

Example

https://web.archive.org/web/20190514165339/http://kokkai.ndl.go.jp/SENTAKU/syugiin/112/0110/11204130110006a.html

Small problem

image

Bigger problem

in the other direction - the highlighted text is in the brownish shade, which is completely obscured by the popup:

image

Cause

This page contains an IFrame which contains a Frameset containing two Frames... By removing some of the structural labyrinth, the misplacement disappeared:

image

I deleted one Frame from the Frameset (without any other modification to the DOM or stylesheets), and the main text body moved to the header area, but the pop-up and highlight are now in correct relative position.

@birtles
Copy link
Member

birtles commented Jul 15, 2023

Thanks for the report. I'll look into it. We have to jump through a lot of hoops to translate positions between iframes so I'm not surprised there are cases that are wrong.

@birtles
Copy link
Member

birtles commented Aug 29, 2023

I had a look into this and it turns out it's not related to iframes, but <frameset> elements 🤯 You can see the problem still reproduces if you open up the archive page directly:

https://web.archive.org/web/20190514165339if_/http://kokkai.ndl.go.jp/SENTAKU/syugiin/112/0110/11204130110006a.html

Talk about a blast from the past.

@birtles birtles changed the title Pop-up misplacement in webpages with complex FRAMEs Pop-up misplacement in webpages with frameset elements Aug 29, 2023
birtles added a commit that referenced this issue Aug 29, 2023
birtles added a commit that referenced this issue Aug 29, 2023
@birtles
Copy link
Member

birtles commented Sep 13, 2023

Version 1.15 has now been released which includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants