Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "added SENTRY_ENV environment variable" #213

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

matprov
Copy link
Collaborator

@matprov matprov commented Nov 16, 2021

This reverts commit c461a17.

Overview

This PR corrects a critical issue in 0.7.6.
According to https://develop.sentry.dev/config/, we only need to define SENTRY_ENVIRONMENT.

The issue in question:

finch         |   File "/code/finch/__init__.py", line 7, in <module>
finch         |     from .wsgi import application  # noqa: F401
finch         |   File "/code/finch/wsgi.py", line 11, in <module>
finch         |     sentry_sdk.init(os.environ["SENTRY_DSN"], SENTRY_ENV)
finch         |   File "/opt/conda/envs/finch/lib/python3.9/site-packages/sentry_sdk/hub.py", line 105, in _init
finch         |     client = Client(*args, **kwargs)  # type: ignore
finch         |   File "/opt/conda/envs/finch/lib/python3.9/site-packages/sentry_sdk/client.py", line 85, in __init__
finch         |     self.options = get_options(*args, **kwargs)  # type: Dict[str, Any]
finch         |   File "/opt/conda/envs/finch/lib/python3.9/site-packages/sentry_sdk/client.py", line 52, in _get_options
finch         |     options = dict(*args, **kwargs)
finch         | ValueError: dictionary update sequence element #0 has length 1; 2 is required

Changes:

  • Reverted commit that adds SENTRY_ENV to sentry SDK config

@matprov matprov requested a review from huard November 16, 2021 15:55
@huard huard merged commit 6c9badb into master Nov 16, 2021
@huard huard deleted the revert_sentry_env branch November 16, 2021 16:33
huard added a commit to bird-house/birdhouse-deploy that referenced this pull request Nov 17, 2021
Update Finch to v0.7.7

Changes
Non-breaking changes

New component version Finch:0.7.7
Related Issue / Discussion
Additional Information
Revert "added SENTRY_ENV environment variable" by @matprov in #213
Refresh notebooks by @Zeitsperre in bird-house/finch#201
Add SENTRY_ENV param by @matprov in bird-house/finch#203
Multiple rcps for ensemble processes by @aulemahal in bird-house/finch#202
Remove bugging drop after geoserver upgrade by @aulemahal in bird-house/finch#207
Update to xclim 0.31 by @aulemahal in bird-house/finch#209
Fix xarray, dask and gunicorn related hang by @cjauvin in bird-house/finch#204
run load() before switching to single-threaded scheduler by @huard in bird-house/finch#211
Add average flag for ensemble processes by @aulemahal in bird-house/finch#210
Revert "added SENTRY_ENV environment variable" by @matprov in bird-house/finch#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants