Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset comment not added to PR #31

Closed
stylesuxx opened this issue Oct 3, 2022 · 3 comments
Closed

Asset comment not added to PR #31

stylesuxx opened this issue Oct 3, 2022 · 3 comments
Assignees
@stylesuxx
Labels
fix

Comments

@stylesuxx
Copy link
Contributor

stylesuxx commented Oct 3, 2022 •
edited
Loading

For some reason attaching the assets failed in this build https://github.com/bird-sanctuary/bluejay/actions/runs/3177380132/jobs/5177750846 although there is a PR... Not sure what the issue here is exactly - @saidinesh5 any idea? Maybe because it's not rebased on the changes yet?
@stylesuxx
Copy link
Contributor Author

Closing this down - worked with the latest PR, no need to debug this one if it keeps working...

@stylesuxx stylesuxx reopened this Oct 10, 2022
@stylesuxx
Copy link
Contributor Author

stylesuxx commented Oct 10, 2022 •
edited
Loading

Re-opened, it's happening again here: #12
I think the on: pull_request might only be triggering on initial pull requests and forced pushes (synchronize)

It is also not triggering the build when closing and re-opening the PR.
It is triggering after rebasing and force pushing.
It is triggering after pushing new commits (only after rebase?).

@stylesuxx stylesuxx self-assigned this Oct 10, 2022
@stylesuxx stylesuxx added the fix label Oct 10, 2022
@stylesuxx stylesuxx mentioned this issue Jan 4, 2023
Closed
@stylesuxx
Copy link
Contributor Author

This should be fixed with the new asset commenter - closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stylesuxx stylesuxx

Labels
fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stylesuxx