Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB51 Adaptations #12

Merged
merged 4 commits into from
Oct 31, 2022
Merged

BB51 Adaptations #12

merged 4 commits into from
Oct 31, 2022

Conversation

stylesuxx
Copy link
Contributor

@stylesuxx stylesuxx commented Sep 8, 2022 •
edited
Loading

See #6

  • Rebase on latest develop

Issues:

  • Reported EDT temperature is double of what it should be - probably because we left the gain at 1

@stylesuxx stylesuxx self-assigned this Sep 9, 2022
saidinesh5
saidinesh5 reviewed Sep 10, 2022
View reviewed changes
BLHeliBootLoad.inc Outdated Show resolved Hide resolved
damosvil
damosvil requested changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@damosvil damosvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, when possible could you check those findings? I think that some changes may be necessary

Bluejay.asm Show resolved Hide resolved
Bluejay.asm Show resolved Hide resolved
Common.inc Outdated Show resolved Hide resolved
Layouts/Base.inc Outdated Show resolved Hide resolved
Layouts/Base.inc Show resolved Hide resolved
tools/build.sh Outdated Show resolved Hide resolved
BLHeliBootLoad.inc Show resolved Hide resolved
@stylesuxx stylesuxx marked this pull request as ready for review September 18, 2022 19:30
@stylesuxx
Copy link
Contributor Author

Alright, I squashed my commits and this is my proposal for the BB51 adaptations.

@damosvil and I tested this on the test boards. I would appreciate if @saidinesh5 and @Burdalfis could too.

@stylesuxx
Copy link
Contributor Author

@damosvil I now changed gain to 1 and left the old TEMP_LIMIT value of 49. I tested this with the C_X layout and did not notice any difference - could reproduce the exact sasme RPMs at the same current.

Would appreciate others testing this too, but I think this PR is now really good to go.

damosvil
damosvil reviewed Sep 25, 2022
View reviewed changes
Layouts/BB51/C.inc Outdated Show resolved Hide resolved
@github-actions
Copy link

Here are the build results
bluejay_ci_14
Artifacts will only be retained for 30 days.

@stylesuxx stylesuxx linked an issue Oct 3, 2022 that may be closed by this pull request
Layouts for BB51 #6
Closed
21 tasks
@stylesuxx
Copy link
Contributor Author

Rebased on latest develop. H and L hex files are binary matches:

Total files: 1548; New files: 108
All existing files match!

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Here are the build results
bluejay-ci-40
Artifacts will only be retained for 30 days.

@stylesuxx
Copy link
Contributor Author

Alright, so the last commits adjust EDT temp and temp protection for the different values of internal temp sensor on the BB51.

To summarize - the 0ºC offset is different on BB2 and BB51 temperature sensor according to data sheet.

On BB2 0x0100 means we are at around 22.5ºC, thats why we can ignore the hi byte and simply add 20ºC if its not zero.
On BB51 0x0114 means we are at 0ºC, in this case we can not simply add 20ºC if hi byte is non zero, instead we detuct 0x14 from the low byte and encode that as the EDT temp.

The temp protection only needed the TEMP_LIMIT value adjusted, to shift it accordingly. In both cases we can ignore the hi byte if zero, since it will definetly be below the first threshold of 80ºC.

@stylesuxx stylesuxx mentioned this pull request Oct 10, 2022
Closed
@stylesuxx stylesuxx closed this Oct 10, 2022
@stylesuxx stylesuxx reopened this Oct 10, 2022
@github-actions
Copy link

Here are the build results
bluejay-ci-43
Artifacts will only be retained for 30 days.

@stylesuxx
chore: gain and temperature adjustments for BB51
b6ab8c1 
* BB51 has internal reference voltage of 1.65V for ADC, thus we use gain of 0.5 to fully scale up back to 3.3V (this is recommended over using different VDD input ranges as ref)
* BB51 Temperature sensor has a different 0degC offset. A high byte of 0x01 is NOT an indication that the temperature is 22.5degC (as it does on BB1 and BB2), instead on the BB51 0x0114 is the 0degC offset.
* An adjusted `TEMP_LIMIT` is enough for the temp protection to do its job properly since it is ignoring the hi byte anyway (22.5degC and < 0degC are not high enough temps to trigger it in any way)
@github-actions
Copy link

Here are the build results
bluejay-ci-44
Artifacts will only be retained for 30 days.

@github-actions
Copy link

Here are the build results
bluejay-ci-45
Artifacts will only be retained for 30 days.

@github-actions
Copy link

Here are the build results
bluejay-ci-46
Artifacts will only be retained for 30 days.

@stylesuxx
Copy link
Contributor Author

Alright, so now a couple users have run this on their BetaFPV AIO's I am feeling rather confident to release this. Or at least pre-release it.

@saidinesh5 @damosvil @Burdalfis any objections?

@damosvil
Copy link
Contributor

damosvil commented Oct 13, 2022 •
edited
Loading

I think we can have a release. It is working fine on my side

@saidinesh5
Copy link
Contributor

I plan to test this out on my hardware this Monday and share my details too.

@howels
Copy link

howels commented Oct 14, 2022

FWIW this worked on a test board, but the board is no longer functioning.

@stylesuxx
Copy link
Contributor Author

FWIW this worked on a test board, but the board is no longer functioning.

Hmm, crap - which Layout was that?

@howels
Copy link

howels commented Oct 14, 2022

FWIW this worked on a test board, but the board is no longer functioning.

Hmm, crap - which Layout was that?

A-X-5. Got hot, osd stopped working. Suspect a faulty board instead of bad firmware.

@stylesuxx
Copy link
Contributor Author

A-X-5. Got hot, osd stopped working. Suspect a faulty board instead of bad firmware.

Mhh, I see, so the main MCU is broken - you can't connect with BF, right?

@howels
Copy link

howels commented Oct 15, 2022

A-X-5. Got hot, osd stopped working. Suspect a faulty board instead of bad firmware.

Mhh, I see, so the main MCU is broken - you can't connect with BF, right?

Can't connect, no led with usb or lipo.

@stylesuxx
Copy link
Contributor Author

A-X-5. Got hot, osd stopped working. Suspect a faulty board instead of bad firmware.

Mhh, I see, so the main MCU is broken - you can't connect with BF, right?

Can't connect, no led with usb or lipo.

OK, then I'd safely assume it was not an issue with Bluejay. Worst case with bluejay you would pop some FETs, or kill a motor.

@stylesuxx stylesuxx mentioned this pull request Oct 17, 2022
Closed
@stylesuxx stylesuxx merged commit bf1c724 into develop Oct 31, 2022
@stylesuxx stylesuxx deleted the feature/6-bb51-adaptations branch October 31, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saidinesh5 saidinesh5 saidinesh5 left review comments

@damosvil damosvil damosvil approved these changes

@Burdalfis Burdalfis Awaiting requested review from Burdalfis

Assignees

@stylesuxx stylesuxx

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layouts for BB51
4 participants
@stylesuxx @damosvil @saidinesh5 @howels