Add functionality to support two char layouts. Add OA layout. #113 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
damosvil
reviewed
Jun 14, 2023
|
Test hardware should soon arrive, I will re-base and build a test hex asap. |
stylesuxx
force-pushed
the
feature/more-layouts
branch
from
9f1689b
to
71dec82
Compare
damosvil
approved these changes
Jun 21, 2023
stylesuxx
added a commit
that referenced
this pull request
Jul 14, 2023
* Codebase splitted in modules * Updated makefile for splitting * 'Cherry picked' 0.19.2 bugfix. * Update editorconfig * Removed dangling ENDIF * Open bootloader file with banner * Add autoformatter and linting tool * Initial pass with the formatter * Disable comment formatting by default (except inline comments) * Make sure all files end with an empty line * Unified comments in layout files according to #96 * Unified comments in accordance to #96 * Unified pinouts in main and layout files #13 * Do not remove spaces in inline comments * Last pass with the formatter * This commit reduces the scheduler timebase from 16ms to 128ms to interfere the minimum with commutation * Refactored duplicate assignments #99 (#101) * Refactored duplicate assignments * Refactored CSEG definitions into separate file * Refactored MCU types and checks * Fixed check time bug and replaced schedule time literals by macros * Replaced Stop_Adc and Start_Adc macro calls by Reastart_Adc macro call * Updated names to more descriptive. Added parameter to select timebase depending on the needs. Scheduler cycle set to 1024ms by default. * Add 'enums' for PWM frequency and resolution #103 (#104) * Bugfix/bring back bidirectional 3d mode (#105) * Fixed temperature limiting affecting to 3D mode. * Fixed Pwm_Limit_By_Rpm to match comments concept * Implemented EDT safety arm feature * Disable temp protection by default #95 (#100) * Add ENUM for DSHOT commands (#117) * Refactored MCU specific offsets to separate module (#116) * Use a single macro for values. (#120) * Renamed functions to improve readability * Update melody size and tag count to be a single macro * Implemented lock and unlock flash macros (#121) * Refactored 16 bit division by two into seperate macro #112 (#119) * Initial draft for supporter section (#89) * Bump version number and mark as DEV version #122 (#124) * Add TuneRC and T-Motor to the supporter section #85 * Add functionality to support two char layouts. Add OA layout. #113 (#114) * Removed relative jumps (#126) * Added/improved a couple of comments to better explain what is going on. (#107) * Improved documentation, unified formatting, added explanations where necessary. * Disable dithering by default (#130) * Allow version string to be passed to Makefile via buildscript (for naming resulting files) (#128) * RC7 tag (#132) * Apply version also if building all files * Fixed RC version * Further reducing motor speed before changing direction in 3D bidirectional mode (#138) * RC10 * Add happymodel and weebleed to the 'Supporters' section #139 (#140)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion for 2 character layouts.
We would be able to add new layouts with new numbers basically arbitrarily. I think this is better than going in alphabetical order since we can relate new layouts. For example, the new
OAlayout is based on theOlayout - the relationship is pretty clear just by the name.Technically this implementation would also allow us to use longer layout names - basically all the additional space that is blocked by spaces in the end could be used as layout name - I would not do it for now, but it would be an option.
I also asked over at BLHeli if there are any plans of adding more layouts, if that would be the case we would need make sure to have them properly synced up (bitdump/BLHeli#698).
Open for suggestions here though - I am aware that it's not as elegant with the direct conversion from letter to ASCII code and such, but it seems like the most pragmatic solution.