Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Add a privacy manifest? #32

Closed
birdofpreyru opened this issue Mar 26, 2024 · 6 comments
Closed

iOS: Add a privacy manifest? #32

birdofpreyru opened this issue Mar 26, 2024 · 6 comments
Labels
P2 Important issue. Ready Ready for release.

Comments

@birdofpreyru
Copy link
Owner

See: itinance#1232

@birdofpreyru birdofpreyru added the P2 Important issue. label Mar 26, 2024
birdofpreyru added a commit that referenced this issue Mar 26, 2024
@birdofpreyru birdofpreyru added the In Progress Work in progress. label Mar 27, 2024
@birdofpreyru
Copy link
Owner Author

Looking at this: https://github.com/zoontek/react-native-permissions/pull/861/files — I've missed to reference the manifest file in Podspec.

@raphaelheinz
Copy link

Hi @birdofpreyru,
when generating a privacy report in XCode, following error is displayed.

privacypolicy

However, uploading to TestFlight works without any problems :)
I think the issue is that 1e75477 does not contain key NSPrivacyCollectedDataTypes. We should add it, even if it is empty...

If you like I can also open a PR.

@JOSEJ94
Copy link

JOSEJ94 commented Apr 29, 2024

Hi, thank you for all your effort on maintaining this package, you're truly heroes!
Apologies for putting pressure on you all, but is this going to be released any time soon ? We're 2 days away from this becoming a blocker.

As a workaround for anyone reading this. Please add this patch to your projects. (It's the same change PR #38 included)

diff --git a/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy b/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
index c6976be..1e4b47e 100644
--- a/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
+++ b/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
@@ -26,5 +26,7 @@
 	<array/>
 	<key>NSPrivacyTracking</key>
 	<false/>
+	<key>NSPrivacyCollectedDataTypes</key>
+	<array/>
 </dict>
 </plist>

@birdofpreyru
Copy link
Owner Author

Ok @JOSEJ94 , I just released it as v2.24.6. I did not know it was any urgent, thus wasn't thinking to release before I find time to do the library upgrade for RN@0.74 (#39).

@JOSEJ94
Copy link

JOSEJ94 commented Apr 29, 2024

Thank you so much! I'm not used to write in any repo, but in this case It was kind of urgent! You can get more information about this here. I have installed it and tested it by submitting a build into testflight and can confirm it's no longer giving warnings

@birdofpreyru birdofpreyru added Ready Ready for release. and removed In Progress Work in progress. labels Apr 30, 2024
@birdofpreyru
Copy link
Owner Author

Great, @JOSEJ94 I take your words as it is confirmed to work alright, and thus this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issue. Ready Ready for release.
Projects
None yet
Development

No branches or pull requests

3 participants