This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Add option to list asset by creating new issue #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text links to a template in bisq-network/bisq that can only be accessed through the URL that specifies the template.
This was referenced Jan 25, 2019
|
Closing, as both PRs have been merged. |
|
This...was never merged. Not sure what I was thinking. @ManfredKarrer would you mind taking a look and ACKing if okay? |
ManfredKarrer
approved these changes
Mar 20, 2019
| == Instructions | ||
| If your asset meets the prerequisites listed above, you may open a new issue in the bisq-network/bisq repository using this link: | ||
|
|
||
| https://github.com/bisq-network/bisq/issues/new?template=new_asset.md[Create issue to request new asset listing^] |
There was a problem hiding this comment.
Should that link work already? I dont see the template
There was a problem hiding this comment.
It works right now...template is here:
https://github.com/bisq-network/bisq/blob/master/.github/ISSUE_TEMPLATE/new_asset.md
|
|
||
| WARNING: Creating an issue to list a new asset is not a guarantee that your asset will be listed. It's a request to convince a Bisq developer to spend the time needed to implement the new asset, write tests, etc. You can help by making a request that is complete and well-formed, and by being cooperative throughout the process. | ||
|
|
||
| If you have the resources to make a pull request yourself, you are welcome to do so by following the directions below. |
There was a problem hiding this comment.
I would add something like:
Be sure to make the PR EXACTLY as described below, not rul-conform PRs will be closed by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new guidelines on new asset listings, which allows requests for new assets to be issues instead of pull requests.
This PR should be merged at the same time as this one.