Rewrite for performance and testability reasons #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use spring boot instead of spark - Introduce separate endpoints for sending to APNs vs FCM - Deprecate relay endpoint (to be removed once clients are updated to use the new APNs/FCM specific endpoints) - Add tests
devinbileck
changed the title
|
This is now running in production. |
This was referenced Mar 26, 2024
|
@alejandrogarcia83 are you able to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the biggest issues with the old code base was its poor performance; the production instance was always at/near 100% CPU. Also, it was hard to update/extend due to its structure and lack of tests. Therefore, a complete rewrite was necessary.
Changelog
Outstanding tasks