Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redirects #164

Merged
merged 3 commits into from
May 14, 2019
Merged

Update redirects #164

merged 3 commits into from
May 14, 2019

Conversation

devinbileck
Copy link
Member

No description provided.

@m52go
Copy link
Contributor

m52go commented Apr 12, 2019 •
edited
Loading

Is there a chance we could add some kind of identifier in these URLs to act as a sort of 'namespace' (so to speak) that refers to their purpose?

Like https://bisq.network/dao-compensation/ instead of https://bisq.network/compensation/.

Only because it would be nice to be able to link to use clean URLs like https://bisq.network/compensation/ for user-facing documentation/materials.

Not super critical, but thought I'd suggest it.

@devinbileck
Copy link
Member Author

Good point. Just not sure which is best?
/dao-compensation
/compensation-requests
...

And perhaps these need to be changed as well?
/proposals
/roles
/reimbursement

@devinbileck
Copy link
Member Author

devinbileck commented Apr 12, 2019 •
edited
Loading

@ManfredKarrer I guess it is going to cause problems if I change the links to /dao-roles in BondedRoleType. I did it on my local and my DAO state seems to be out of consesus now. So I will have to leave /roles as is.

@devinbileck
Update DAO related redirects
fa6ac2b 
To make them more specific and free them up for potential user-facing
documentation/materials.

Note, the /roles redirect was intentionally not updated as it is currently
specified in BondedRoleType and cannot be changed without causing
consensus issues.
devinbileck added a commit to devinbileck/bisq that referenced this pull request Apr 13, 2019
@devinbileck
Update links based on bisq-network/bisq-website#164
69df47d
@ManfredKarrer
Copy link
Contributor

Hm, not clear to me why that could cause a consensus issue, but don't have the time atm for lookinng into that.
Regarding proposal: We use that atm for kind of BIP style proposals which are different to DAO proposals. Would like to avoid to mix it not inflate the BIP style proposals. Maybe we should rename the proposals to something different (BisqIP)?

@devinbileck
Copy link
Member Author

There are different types of proposals? Don't the BIP-style proposals now require voting upon via the DAO?

@devinbileck
Copy link
Member Author

Something like BEP Bisq Enhancement Proposal and BDP Bisq DAO Proposal?

@devinbileck
Copy link
Member Author

I attempted to change the links to /dao-roles in BondedRoleType again but this time did not encounter consensus issues with the DAO state. So appears to be ok to change those.

ManfredKarrer
ManfredKarrer approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit ce9dfda into bisq-network:master May 14, 2019
@ManfredKarrer
Copy link
Contributor

I attempted to change the links to /dao-roles in BondedRoleType

I prefer to not change that. Not worth the risk.

@devinbileck devinbileck mentioned this pull request May 15, 2019
Merged
@devinbileck devinbileck deleted the update-redirects branch May 15, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinbileck @m52go @ManfredKarrer