Merge pull request #3734 from freimair/fix_thread_leak

Fix resource leak caused by not cleaning up unused threads
bisq-network · Dec 4, 2019 · d0bed93 · d0bed93
2 parents 037f167 + 5f37be1
commit d0bed93
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/p2p/src/main/java/bisq/network/p2p/network/Connection.java b/p2p/src/main/java/bisq/network/p2p/network/Connection.java
@@ -539,6 +539,7 @@ private void doShutDown(CloseConnectionReason closeConnectionReason, @Nullable R
 
             //noinspection UnstableApiUsage
             MoreExecutors.shutdownAndAwaitTermination(singleThreadExecutor, 500, TimeUnit.MILLISECONDS);
+            MoreExecutors.shutdownAndAwaitTermination(bundleSender, 500, TimeUnit.MILLISECONDS);
 
             log.debug("Connection shutdown complete " + this.toString());
             // Use UserThread.execute as its not clear if that is called from a non-UserThread