Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Funds needed" info button freaks out #3016

Closed
fresheneesz opened this issue Jul 27, 2019 · 4 comments · Fixed by #3211
Closed

"Funds needed" info button freaks out #3016

fresheneesz opened this issue Jul 27, 2019 · 4 comments · Fixed by #3211
Labels
a:bug good first issue in:gui

Comments

@fresheneesz
Copy link

When I hover my mouse onto the info "i" button from the bottom, the info pane flashes open and closed at a rate of about 20 times per second. This is it caught mid flip out:

bisqfundsneeded

Please fix.
@ghost
Copy link

ghost commented Jul 28, 2019

I have some similar effect with my Debian/Gnome.
I guess this is managed by a GUI library and caused by it.
So, probably few chance we can do something here.

@fresheneesz
Copy link
Author

I guess this is managed by a GUI library and caused by it. So, probably few chance we can do something here.

What makes you say that? Most times when I've seen behavior like this, its because the opening of the dialog changes the state that causes the dialog to close, which changes the state causing the dialog to open again. For example, if you have a dialog open under where the mouse is, the mouse may not be recognized as hovering over the "i" element anymore, causing the dialog to close, which causes the mouse to be recognized as hovering over the "i" element again, causing the dialog to open... etc etc. Do you think that's not what's happening?

@ghost
Copy link

ghost commented Jul 29, 2019

What makes you say that? ... Do you think that's not what's happening?

It was just a guess from my side. I'm not a java and GUI dev.
Thanks for your explanation. Hopefully you're right and so something is doable.
ping @ripcurlx since he manages the GUI.

@fresheneesz
Copy link
Author

Ugh, this also happens to the "Amount in USD to spend" field's eye-icon in the "Create new offer to buy bitcoin" view, but even worse, there's no position where it won't freak out.

stejbac added a commit to stejbac/bisq that referenced this issue Sep 5, 2019
@stejbac
Prevent tooltip popover flicker upon mouseover
a2c1244 
Provide a wrapper for PopOver components used as tooltips, to debounce
the 'MouseEntered' and 'MouseExited' events used to show/hide it, in
order to prevent it flickering open/closed in a loop. This fixes bisq-network#3016.

To this end, use a ..->HIDDEN->SHOWING->SHOWN->HIDING->.. state field,
together with a target visibility boolean field, where the transition
between HIDDEN and SHOWN incurs a small fixed delay.
@stejbac stejbac mentioned this issue Sep 5, 2019
Merged
stejbac added a commit to stejbac/bisq that referenced this issue Sep 29, 2019
@stejbac
Prevent tooltip popover flicker upon mouseover
6b0a515 
Provide a wrapper for PopOver components used as tooltips, to debounce
the 'MouseEntered' and 'MouseExited' events used to show/hide it, in
order to prevent it flickering open/closed in a loop. This fixes bisq-network#3016.

To this end, use a ..->HIDDEN->SHOWING->SHOWN->HIDING->.. state field,
together with a target visibility boolean field, where the transition
between HIDDEN and SHOWN incurs a small fixed delay.
stejbac added a commit to stejbac/bisq that referenced this issue Nov 9, 2019
@stejbac
Prevent tooltip popover flicker upon mouseover
dd56b3a 
Provide a wrapper for PopOver components used as tooltips, to debounce
the 'MouseEntered' and 'MouseExited' events used to show/hide it, in
order to prevent it flickering open/closed in a loop. This fixes bisq-network#3016.

To this end, use a ..->HIDDEN->SHOWING->SHOWN->HIDING->.. state field,
together with a target visibility boolean field, where the transition
between HIDDEN and SHOWN incurs a small fixed delay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug good first issue in:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent tooltip popover flicker upon mouseover stejbac/bisq
2 participants
@fresheneesz @freimair