-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent spent tx / depositTx is null when taking offer #3721
Comments
@julianknutsen Thanks for finding that! I could reproduce it. It seems BitcoinJ has problems with a tx where you do not receive anything. Still investigating what exactly is the reason and how we can fix that but for now the mediators should not make suggested payouts with one peer getting all and the other nothing to avoid that scenario until we have fixed it. They got informed to follow that until its solved. |
Ah we do not filter out the 0 BTC output! mediated payoutTx:
|
Fixes bisq-network#3721 and bisq-network#3722 There are still more issues as such a payout tx will cause that the trade ends up in failed trades. This commit only fixes the invalid tx issue.
Fixes bisq-network#3721 (part of the problem was that the trade ended up in failed trade) Refactor method and add comments. We did not handle the case of a mediated payout. isPayoutPublished() is only reflecting non-disputed trade payouts.
Fixed the moving to failed trade bug: #3726 |
I'm having a hard time keeping the bugs separate for each fix. Any other bug references I can look at for user-submitted ones? Are there two separate issues here?
|
Added one: #3727 |
* Do not add an output if value is 0 BTC Fixes #3721 and #3722 There are still more issues as such a payout tx will cause that the trade ends up in failed trades. This commit only fixes the invalid tx issue. * Refactoring: Replace isGreaterThan(Coin.ZERO) with isPositive() * Do not display confirmation icon for 0 BTC tx If we do not get any BTC from a mediated payout tx we do not know about the confirmation state so it would stay always in the unconfirmed state. To avoid that confusion we prefer to hide the icon. This is a known issue from BitcoinJ but we have not found a solution for that yet.
Fixes #3721 (part of the problem was that the trade ended up in failed trade) Refactor method and add comments. We did not handle the case of a mediated payout. isPayoutPublished() is only reflecting non-disputed trade payouts.
Confirmed that the TestPad test case now passes on c2e8806 |
Description
When taking an offer an error is presented and error logs display "Inconsistent spent tx:" and "depositTx is null".
Offer appears in "Open Trades" with no available actions.
After restarting Alice & Bob the option is available to move to "Failed Trades".
It looks like the multisig payout transaction from mediation on Bob (mediation payed out all to Alice) is the issue. I have 0% experience with that part of the codebase, but that is the common bad txn across runs.
Version
548a217
Steps to reproduce
100% repro over three runs with the following steps:
Alice - fullDaoNode | Bob - (non-fullDaoNode || fullDaoNode)
Arbitration/Support Process: 002
Arbitration/Support Process: 009
Expected behaviour
It works, or a more useful error message is presented.
Actual behaviour
Error popup, log errors, and failed trade.
Screenshots
Error Logs
![inconsistent_spent_tx](https://user-images.githubusercontent.com/8082291/69920022-0900e880-1438-11ea-9212-73114b0da79a.JPG)
Transactions
![inconsistent_spent_bob_txns](https://user-images.githubusercontent.com/8082291/69920025-09997f00-1438-11ea-9420-95c4e8f541b2.JPG)
![inconsistent_spent_alice_txns](https://user-images.githubusercontent.com/8082291/69920026-09997f00-1438-11ea-863d-6fb0c5b7917f.JPG)
Funds Tab
![inconsistent_spent_bob_funds](https://user-images.githubusercontent.com/8082291/69920027-0a321580-1438-11ea-8673-0879ab08440d.JPG)
![inconsistent_spent_alice_funds](https://user-images.githubusercontent.com/8082291/69920028-0a321580-1438-11ea-8c94-e149848ce7d6.JPG)
Bob Trade Info
![inconsistent_spent_bob_trade_info](https://user-images.githubusercontent.com/8082291/69920024-09997f00-1438-11ea-8227-ac358a387b71.JPG)
After Restart:
![inconsistent_spent_bob_after_restart](https://user-images.githubusercontent.com/8082291/69920023-09997f00-1438-11ea-8819-e5d522b6f677.JPG)
After SPV Resync
![inconsistent_spent_bob_after_spv_resync](https://user-images.githubusercontent.com/8082291/69920216-ea035600-1439-11ea-8524-c91e93df23ec.JPG)
Device or machine
Ubuntu 19.10
Additional info
alice-bisq.log
bob-bisq.log
The text was updated successfully, but these errors were encountered: