Add altcoin payment method for live trading #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LiveAsset account, payment method, AccountPayload - Extract super classes for normal CryptoCurrenyAccount and payload and LiveAssetAccount and payload - Add isAsset method - Add button for creating a live asset account As it is a bit tricky to use the AccountForm for both methods and add a checkbox there so defined which payment method to use I added a button to add an AccountForm with the LiveAssets passed. This is just temporary to be able to test a bit more and see if there are any critical issues. We should unify that form but that might require a bit of refactoring of the CryptoCurrencyForm.
ripcurlx
reviewed
Mar 4, 2019
ripcurlx
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveAssetAccount and payload
As it is a bit tricky to use the AccountForm for both methods and add a
checkbox there so defined which payment method to use I added a button
to add an AccountForm with the LiveAssets passed. This is just
temporary to be able to test a bit more and see if there are any
critical issues. We should unify that form but that might require a bit
of refactoring of the CryptoCurrencyForm.