Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect transaction size shown for bonding #2652

Merged

Conversation

devinbileck
Copy link
Member

When locking up or unlocking a bond, the displayed transaction size was
in bytes, but the prompt was indicating it was Kb. So adjust the value
so it is shown as Kb.

Before:
image

After:
image

When locking up or unlocking a bond, the displayed transaction size was
in bytes, but the prompt was indicating it was Kb. So adjust the value
so it is shown as Kb.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Good catch 👍! I quickly checked the other places where we display Kb and it looks like it is correctly calculated everywhere else.

@ripcurlx ripcurlx merged commit de3a2ba into bisq-network:master Apr 5, 2019
@devinbileck devinbileck deleted the fix-incorrect-txsize-for-bonding branch April 5, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants