-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List uPlexa (UPX) #3350
List uPlexa (UPX) #3350
Conversation
If this is privacy coin you have to warn users (when they create payment account) that only transparent addresses are allowed. Have a look how it's done here: https://github.com/bisq-network/bisq/pull/2433/files |
0ef3c63
to
a3176d4
Compare
Thanks @blabno, I have gone a head and added the warning regarding TX verification/proof and squashed to one commit. Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK per comments
import bisq.asset.Coin; | ||
import bisq.asset.RegexAddressValidator; | ||
|
||
public class uPlexa extends Coin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add AltCoinAccountDisclaimer
annotation with proper key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for missing that. Updated & tested.
a3176d4
to
f5f4611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Additional: UPX wallets support transaction keys that enable 3rd party audits in case of a dispute similar to Monero
Included: Support for standard addresses (UPX), sub-addresses (UmV & UmW), and integrated address (UPi)