Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List uPlexa (UPX) #3350

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

QuantumLeaper
Copy link
Contributor

@QuantumLeaper QuantumLeaper commented Oct 1, 2019

Additional: UPX wallets support transaction keys that enable 3rd party audits in case of a dispute similar to Monero

Included: Support for standard addresses (UPX), sub-addresses (UmV & UmW), and integrated address (UPi)

@blabno
Copy link

blabno commented Oct 3, 2019

If this is privacy coin you have to warn users (when they create payment account) that only transparent addresses are allowed. Have a look how it's done here: https://github.com/bisq-network/bisq/pull/2433/files

@QuantumLeaper QuantumLeaper force-pushed the list-upx-asset branch 2 times, most recently from 0ef3c63 to a3176d4 Compare October 3, 2019 08:57
@QuantumLeaper
Copy link
Contributor Author

Thanks @blabno, I have gone a head and added the warning regarding TX verification/proof and squashed to one commit.

Cheers

Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK per comments

import bisq.asset.Coin;
import bisq.asset.RegexAddressValidator;

public class uPlexa extends Coin {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add AltCoinAccountDisclaimer annotation with proper key.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for missing that. Updated & tested.

Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 70d17ea into bisq-network:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants