Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide avoid standby mode feature on *nux OS #3563

Merged

Conversation

ghubstan
Copy link
Contributor

@ghubstan ghubstan commented Nov 5, 2019

Displays standby mode button on only on Windows and OSX,
and hides it on Linux and Unix distributions.

TitledGroupBg num rows reduced to 7 when standby mode button
is not displayed.

Fixes #3223

Replaces PR #3322 -- rejected because source file reformat
rearanged class level field declarations, making review
more difficult.

Displays standby mode button on only on Windows and OSX,
and hides it on Linux and Unix distributions.

TitledGroupBg num rows reduced to 7 when standby mode button
is not displayed.

Fixes bisq-network#3223

Replaces PR bisq-network#3322 -- rejected because source file reformat
rearanged class level field declarations, making review
more difficult.
@chimp1984
Copy link
Contributor

We still enable it on Unix, no? See AvoidStandbyModeService

@ghubstan
Copy link
Contributor Author

ghubstan commented Nov 6, 2019

We still enable it on Unix, no? See AvoidStandbyModeService

I see nothing in the issues or AvoidStandbyModeService src explicitly saying there are any problems with standby mode on Unix. I had no good reason to assume standby mode won't work on Unix too, but I did.

This PR would disable the feature on all flavors of Unix. I can make sure the feature is not hidden on Unix. Do you want me to do that?

@ripcurlx
Copy link
Contributor

But don't we have a problem for all not Windows and macOS systems if that preference was already set to true? So the sound gets played and they are not able to deactivate it.

@ghubstan
Copy link
Contributor Author

Closing and reopening PR to force travis-ci check.

@ghubstan ghubstan closed this Nov 16, 2019
@ghubstan ghubstan reopened this Nov 16, 2019
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, I share the opinion of @wiz: Linux users have to disable sleep-mode on their own. Showing the switch on Linux promises something that does not work.

@chimp1984
Copy link
Contributor

I think before changing behaviour we should be sure if the existing solution works on Linux and if it is needed as well if there is another better option to do it (e.g. via VM argument).
To test this on OSX was pretty time consuming and difficult. As the result of the sleep mode behaviour can be that take offer attempts fail because the app is too slow to respond in time I think it is a rather serious issue which we only should change if we are sure to improve it. There have been only 1 or 2 people complaining about the sound (probably bad sound card produce artefacts) but before that fix we have many cases of failed take-offer attempts.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - it still runs as before on OSX (tested myself) and Windows and also removes this option on Linux. I agree that it is not good if we leave the user in the impression that this will prevent the application from going into standby mode, which seems to be not true as mentioned in #3223 .

@ripcurlx ripcurlx merged commit 19da79b into bisq-network:master Dec 6, 2019
@ghubstan ghubstan deleted the hide-avoidstandby-feature-on-linux branch December 6, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1.1.6 "Avoid Standby Mode" does not work on Ubuntu 18
4 participants