-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide avoid standby mode feature on *nux OS #3563
Hide avoid standby mode feature on *nux OS #3563
Conversation
Displays standby mode button on only on Windows and OSX, and hides it on Linux and Unix distributions. TitledGroupBg num rows reduced to 7 when standby mode button is not displayed. Fixes bisq-network#3223 Replaces PR bisq-network#3322 -- rejected because source file reformat rearanged class level field declarations, making review more difficult.
We still enable it on Unix, no? See AvoidStandbyModeService |
I see nothing in the issues or AvoidStandbyModeService src explicitly saying there are any problems with standby mode on Unix. I had no good reason to assume standby mode won't work on Unix too, but I did. This PR would disable the feature on all flavors of Unix. I can make sure the feature is not hidden on Unix. Do you want me to do that? |
But don't we have a problem for all not Windows and macOS systems if that preference was already set to true? So the sound gets played and they are not able to deactivate it. |
Closing and reopening PR to force travis-ci check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than that, I share the opinion of @wiz: Linux users have to disable sleep-mode on their own. Showing the switch on Linux promises something that does not work.
desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java
Show resolved
Hide resolved
I think before changing behaviour we should be sure if the existing solution works on Linux and if it is needed as well if there is another better option to do it (e.g. via VM argument). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK - it still runs as before on OSX (tested myself) and Windows and also removes this option on Linux. I agree that it is not good if we leave the user in the impression that this will prevent the application from going into standby mode, which seems to be not true as mentioned in #3223 .
Displays standby mode button on only on Windows and OSX,
and hides it on Linux and Unix distributions.
TitledGroupBg num rows reduced to 7 when standby mode button
is not displayed.
Fixes #3223
Replaces PR #3322 -- rejected because source file reformat
rearanged class level field declarations, making review
more difficult.