Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding for flowpane to resolve moneygram save issue. #3600

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

beingindot
Copy link
Contributor

For #3598

Basically flowpane is hiding email label, hence we could not save. so
@ripcurlx suggested this workaround fix for immeidate push.

ripcurlx
ripcurlx previously approved these changes Nov 12, 2019
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK NACK - as the commit needs to be signed.

@ripcurlx
Copy link
Contributor

@beingindot ACK on the code change - NACK- you need to sign your commits

@ripcurlx ripcurlx dismissed their stale review November 12, 2019 12:28

Missed the non-signed commit

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - as the commit needs to be signed

@ripcurlx ripcurlx merged commit d00179c into bisq-network:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants