Bump javafx version to 11.0.2 #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from various fixes and improvements, it appears that this should resolve bisq-network#2279, as fixed in https://bugs.openjdk.java.net/browse/JDK-8210411 Reference: https://github.com/javafxports/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.0.1.md https://github.com/javafxports/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.0.2.md
ripcurlx
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
ACK - @devinbileck Do you remember why we removed the checksums for javafx from the witness file? I think it was because of the different os jars which we somehow weren't able to implement properly in the witness file.
|
Yes, as far as I remember that is correct. It would be nice to find a solution for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from various fixes and improvements, it appears that this
should resolve #2279, as fixed in
https://bugs.openjdk.java.net/browse/JDK-8210411
Reference:
https://github.com/javafxports/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.0.1.md
https://github.com/javafxports/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.0.2.md