Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OfferView constructor #3655

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Refactor OfferView constructor #3655

merged 1 commit into from
Nov 22, 2019

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Nov 21, 2019 •
edited
Loading

direction is now passed directly to OfferView constructor, instead of doing (this instanceof BuyOfferView) checks in superclass.

Before that is was hard to check what is difference between SellOfferView and BuyOfferView classes.

ripcurlx
ripcurlx approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit c0108b8 into bisq-network:master Nov 22, 2019
@lusarz lusarz mentioned this pull request Nov 27, 2019
Closed
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Closed
@lusarz lusarz deleted the refactor-offer-view branch February 4, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lusarz @ripcurlx