Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EmptyWalletWindow into BsqEmptyWalletWindow and BtcEmptyWalletWindow #3660

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Split EmptyWalletWindow into BsqEmptyWalletWindow and BtcEmptyWalletWindow #3660

merged 1 commit into from
Nov 26, 2019

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Nov 22, 2019

There is a lot of checks like:

if (!isBtc)
        gridPane.getColumnConstraints().remove(1);

if (isBtc)
        addMultilineLabel(gridPane, ++rowIndex, Res.get("emptyWalletWindow.info"), 0);

in EmptyWalletWindow

In this pull request I split this logic into separate classes, to make it more readable.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 46eef93 into bisq-network:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants