Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-review text to Contributing Doc #3692

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

julianknutsen
Copy link
Contributor

@julianknutsen julianknutsen commented Nov 26, 2019

Explicitly state that Pull Requests with changes should ask for a re-review when those changes have been made. This will help the review workflow since reviewers will only need to keep track of PRs in the "review required " state.

This builds off #3691 to help the review workflow.

Explicitly state that Pull Requests with changes should ask for a re-review when those changes have been made. This will help the review workflow since they only need to keep track of PRs in the "review required " state.
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 3c3e20c into bisq-network:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants