Use correct language tags for script and regional language variants #3716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Bisq's language tags so Java's locale class will correctly display the name of script and regional variants of languages. There were previously hard-coded hacks to correctly display the language names correctly, and this PR removes those hacks since they are now properly displayed by Java.
It's actually a common misunderstanding in software localization:
For some people, the difference is subtle:
"en-us" = American English
"en_US" = generic English in USA
"en-gb" = British English
"en-gb_US" = British English in USA
But for other people, the difference is very important:
"br" = Portugese
"br-pt" = Brazilian Portugese
"br-pt_JP" = Brazilian Portugese in Japan
In this case, to merge #3714, I need the following script variant:
"zh" = Chinese
"zh-hans" = Simplified Chinese
"zh-hant" = Traditional Chinese
Needs testing!