Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dark mode switch after restart #3771

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fixes dark mode switch after restart #3771

merged 2 commits into from
Dec 9, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Dec 9, 2019 •
edited
Loading

Also includes a minor cleanup of an unnecessary indirection.
Fixes #3447.0
Superseds #3754.

Test cases

Tested on Regtest.

Set custom withdrawal fee

  • Withdraw BTC from Funds > Send Funds
  • Check withdrawal fee in popup
  • Set in settings a custom withdrawal fee of double value (e.g. 20)
  • Withdraw BTC from Funds > Send Funds
  • Check if withdrawal fee in popup was doubled as well

Toggle dark mode

  • Activate dark mode
  • Check if dark mode was enabled
  • Restart app
  • Deactivate dark mode
  • Check if light mode is enabled

@ripcurlx ripcurlx changed the title Fixes dark monde switch after restart Fixes dark mode switch after restart Dec 9, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 9, 2019
Closed
freimair
freimair approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@freimair freimair merged commit 30f9664 into bisq-network:master Dec 9, 2019
@freimair freimair mentioned this pull request Dec 9, 2019
Closed
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 10, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Closed
@ripcurlx ripcurlx deleted the fix-dark-mode-switch-plus-cleanup branch December 18, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freimair freimair freimair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.

Dark mode not disabled on 1st attempt to turn it off after restart
2 participants
@ripcurlx @freimair