Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macOS app Info.plist setting for automatic light/dark title bar #3883

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Use macOS app Info.plist setting for automatic light/dark title bar #3883

merged 2 commits into from
Jan 16, 2020

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Jan 9, 2020

macOS set to light theme:
Screen Shot 2020-01-10 at 8 07 35

macOS set to dark theme:
Screen Shot 2020-01-10 at 8 07 19

@wiz wiz requested review from ripcurlx and sqrrm as code owners January 9, 2020 23:10
@sqrrm
Copy link
Member

sqrrm commented Jan 10, 2020

@ripcurlx could you test this one?

@ripcurlx
Copy link
Contributor

@ripcurlx could you test this one?

sure

@wiz @ripcurlx
Update desktop/package/macosx/Info.plist
74ff4a0 
Co-Authored-By: Christoph Atteneder <christoph.atteneder@gmail.com>
ripcurlx
ripcurlx approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Create a local build and tested it by switching between:

  • dark mode
    Bildschirmfoto 2020-01-16 um 15 59 43
  • and light mode
    Bildschirmfoto 2020-01-16 um 15 59 50

@ripcurlx ripcurlx merged commit c50a761 into bisq-network:master Jan 16, 2020
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 16, 2020
@wiz wiz deleted the macos-dark-title-bar branch January 16, 2020 16:20
@wiz
Copy link
Contributor Author

wiz commented Feb 13, 2020

@ripcurlx FYI apparently this isn't the right shade of grey, it's supposed to be darker, will have to fix in a separate PR 😂

@cbeams cbeams mentioned this pull request Feb 13, 2020
Closed
ripcurlx added a commit that referenced this pull request Feb 13, 2020
@ripcurlx
Revert #3883
54aa963 
Causes issues on macOS versions before Catalina
ripcurlx added a commit that referenced this pull request Feb 13, 2020
@ripcurlx
Revert #3883
1163b25 
Fixes issue #3969

This setting prevented the startup of the app on macOS Mojave.
Possibly on some other older macOS versions as well.
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@wiz @sqrrm @ripcurlx