Temporarily deactivate public network option #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be in place until we are able to check if a connected Bitcoin Core is configured properly for our requirements
wiz
approved these changes
Feb 5, 2020
ripcurlx
added
the
is:priority
|
It seems Bisq will fallback to using the public Bitcoin network if valid Bitcoin nodes are not configured, which is unreliable. Maybe you should fallback to the provided Bitcoin nodes instead? |
|
Regarding re-enabling the public network option, even with pruning and bloom filter checks in place, see #3982 (comment). |
|
To perform the checks on the local Bitcoin node, we initiate a Bitcoin connection to get information from the handshake and then we close it, just to have Bisq rebuild the connection in case the node is well configured. We might be able to perform these checks by hooking into the regular/existing connection process. In that case the checks would be free in terms of network IO. I might take this up, if there's demand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be in place until we are able to check if a connected Bitcoin Core is configured properly for our requirements.