Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak seednode bitcoin.conf, remove timeout, separate testnet block #4447

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Aug 28, 2020

The timeout line of our bitcoin.conf occasionally causes it to get stuck, should remove it from all nodes.
Also separate testnet into its own block

@wiz
Copy link
Contributor Author

wiz commented Aug 28, 2020

@Emzy this should address the issue you had recently

@Emzy
Copy link
Contributor

Emzy commented Aug 29, 2020

@Emzy this should address the issue you had recently
This was the error in the log:

ProcessNewBlock: AcceptBlock FAILED (prev-blk-not-found (code 0))
ERROR: AcceptBlockHeader: prev block not found

@wiz
Copy link
Contributor Author

wiz commented Aug 30, 2020

@Emzy there is some more relevant log message around that, but basically one of your peers failed to send you a block in time, and because of the long timeout=30000 setting it got stuck and held up your node for a long time. I never meant to commit that line into our configuration, it was a mistake so this PR just removes the timeout, and next time you have a peer with poor connection it will use the default timeout value

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 51e66d5 into bisq-network:master Aug 30, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants