XMR autoconf should get amount from trade not offer #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the amount from the trade rather than the offer. Log the expected amount when not matching the explorer result. It would have made debugging this issue much more straightforward. Fixes #4557
chimp1984
approved these changes
Sep 25, 2020
| @@ -60,8 +60,7 @@ | |||
| this.serviceAddress = serviceAddress; | |||
| this.autoConfirmSettings = autoConfirmSettings; | |||
|
|
|||
| Coin tradeAmount = trade.getTradeAmount(); | |||
| Volume volume = checkNotNull(trade.getOffer()).getVolumeByAmount(tradeAmount); | |||
| Volume volume = trade.getTradeVolume(); | |||
There was a problem hiding this comment.
Good catch. I think the trade price is the reason for the issue.
|
Yes I reproduced the problem by forcing the taker's price to differ from maker's price same way as it was reported in the logs. I did not catch this problem during testing because all were self trades / same machine and so there was no price discrepancy between the trading parties. Also I tended to use a fixed XMR rate which in hindsight was a bit silly as most traders use floating rates. |
sqrrm
approved these changes
Sep 27, 2020
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4557