Setting jvm option -Djdk.module.illegalAccess=deny
#4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng logs at startup Not sure how to add it to gradle so its set at normal compilation as well... User get confused by the warning as it sounds somehow alerting. `WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.2.2/6dacbe18e5eaa7f6c9c36db33b42e7985e94ce77/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release`
chimp1984
changed the title
-Djdk.module.illegalAccess=deny avoids the warn…-Djdk.module.illegalAccess=deny
I guess it is fine as we are not using Java 9 modules so far. It seems to be fixed in google/guice@85e30be, but not released yet. |
cd2357
added a commit
to cd2357/bisq
that referenced
this pull request
Oct 6, 2020
Backport bisq-network#4600 into this PR. Set `-Djdk.module.illegalAccess=deny` in order to reduce warning in startup logs.
chimp1984
deleted the
avoid-illegal-reflective-access-operation-warning
branch
|
FYI: this may work well with Java 10 and the current JavaFX, but it caused issues with guice in #4242 when the packaged app contains more recent JREs (tested with Java 11, 14 and 15). More specifically, when opening the packaged app:
So for now I disabled it in the new jpackage script used in #4242 with 696a788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting jvm option
-Djdk.module.illegalAccess=denyavoids the warning logs at startupNot sure how to add it to gradle so its set at normal compilation as well...
User get confused by the warning as it sounds somehow alerting.
WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.2.2/6dacbe18e5eaa7f6c9c36db33b42e7985e94ce77/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release