Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center align tick marks text for trading charts #4740

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Center align tick marks text for trading charts #4740

merged 1 commit into from
Nov 3, 2020

Conversation

deusmax
Copy link
Contributor

@deusmax deusmax commented Nov 2, 2020

New method addTickMarkLabelCssClass to grab the axis tick label and add a CSS class to it.

Signed-off-by: Deus Max deusmax@gmx.com
Acked-by: Deus Max deusmax@gmx.com

Your PR description here.
@ghubstan as discussed in PR#4175. to center-align tick mark text.
Add a CSS class to the axis tick marks text. The CSS class can be used to add any css command, such as -fx-text-align: center to the labels.
Here is a screenshot of the results:
Bisq-chartaxes-day_centeralign-2020-11-02

New method addTickMarkLabelCssClass to grab the
axis tick label and add a CSS class to it.

Signed-off-by: Deus Max <deusmax@gmx.com>
Acked-by: Deus Max <deusmax@gmx.com>
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested it on Mainnet and it works as expected. Thanks!

@ripcurlx ripcurlx merged commit 00725cf into bisq-network:master Nov 3, 2020
@deusmax deusmax deleted the trading_charts_axes branch November 7, 2020 01:26
@ripcurlx ripcurlx added this to the v1.5.0 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants