Fix bug with reading historical data #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use fileName not getFileName() in readHistoricalStoreFromResources - use complete handler once reading of all historical data is completed where we build the ImmutableMaps and complete the readFromResources method
We used a delegate method in P2PService for calling readPersisted on p2PDataStorage and peerManager. This was from old times when those classed have not been injected classes. The complete handlers got called from both p2PDataStorage and peerManager but we counted only P2PService as host, so the countdown completed before the last host was really completed, leading to a nullpointer in MainView (not always). We removed now PersistedDataHost interface from P2PService and use P2PDataStorage and PeerManager to be added to hosts.
|
ACK (after the fact of merging), as I've tested this locally, and the problem I reported in #4706 (comment) is indeed resolved. There is however another problem still persisting, and I'll comment about that back on the #4706 issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs with reading historical data:
build the ImmutableMaps and complete the readFromResources method
Fixes #4706 (comment)