Account management usability improvements #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widen payment account dropdown in create & edit offer screens Sort payment account dropdown by name in create & edit offer screens Sort account listview by name in manage fiat accounts screen Sort account listview by name in manage altcoin accounts screen Bug fix: do not adjust BTC amount in edit offer screen There was a bug where editing an existing offer could have its payment account changed to one with more restrictive limits and the offer would still be allowed (although not take-able). It should not be allowed to be saved in this case. This change takes proper heed of the "allowAmountUpdate" flag which is false for offer edits. e.g. edit an F2F buy for 0.25, change to Zelle unsigned, the offer will prevent saving.
|
Thanks @jmacxx that was super quick 👍 |
|
@jmacxx It looks like existing tests are failing. Could you please have a look why and adapt it if it is a false positive? Thanks! |
|
Sorry I had got into a bad habit of building with |
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some requests from #4837 :
There was a bug where editing an existing offer could have its payment account changed to one with more restrictive limits and the offer would still be allowed (although not take-able). It should not be allowed to be saved in this case. This change takes proper heed of the
allowAmountUpdateflag which is false for offer edits.e.g. edit an F2F buy for 0.25, change to Zelle unsigned, the offer will prevent saving.
Ref: #4837 (comment)