Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve funds and portfolio screens #4933

Merged
merged 6 commits into from
Dec 14, 2020
Merged

Improve funds and portfolio screens #4933

merged 6 commits into from
Dec 14, 2020

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Dec 10, 2020 •
edited
Loading

  • Add export to csv to locked funds and reserved funds screens
  • Add num items to tables
  • Show num trades in pending trades badge and peer icon also if > 9 (was * before)
  • Move filter input field in history to top, fix label
  • Add enable/disable all toggle to open offers
  • Add search field to open offers and failed trades
  • Improve search

@chimp1984
Copy link
Contributor Author

Screen Shot 2020-12-11 at 00 22 09

Screen Shot 2020-12-11 at 00 22 17

Screen Shot 2020-12-11 at 00 22 25

Screen Shot 2020-12-11 at 00 22 44

@chimp1984 chimp1984 changed the title Improve fund screens Improve fund and portfolio screens Dec 11, 2020
@chimp1984 chimp1984 changed the title Improve fund and portfolio screens Improve funds and portfolio screens Dec 11, 2020
ripcurlx
ripcurlx approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Changed behavior of toggle all button if no offers are available

@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 14, 2020
chimp1984
chimp1984 commented Dec 14, 2020
View reviewed changes
Copy link
Contributor Author

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested new commit and behaves as expected (ACK)

@ripcurlx ripcurlx merged commit 7d12b94 into bisq-network:master Dec 14, 2020
@chimp1984 chimp1984 deleted the add-num-items-to-tables branch December 14, 2020 19:23
@ripcurlx
Copy link
Contributor

Bildschirmfoto 2020-12-18 um 10 29 29
Bildschirmfoto 2020-12-18 um 10 29 22

Just recognized it won't work for three digits and higher. I'll push a fix soon with some other minor fixes.

@chimp1984 chimp1984 mentioned this pull request Dec 26, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Dec 28, 2020
Closed
@pazza83
Copy link

pazza83 commented Jan 3, 2021

Thanks for all these changes they are fantastic!! Lots of improvements :)

I would suggest the following to make it even better and improve consistency:

Funds screens

  • Add 'Filter' to ALL Funds screens if possible

Open trades screen

  • Add 'Filter' to open trades
  • Add 'deviation' to open trades
  • As well as 'Number of entries' on open trades add 'Number of enabled entries'
  • Add 'export to CSV' for open trades

Failed trades screen

  • Add 'deviation' and 'payment method' to failed trades

@ripcurlx ripcurlx mentioned this pull request Jan 13, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Jan 27, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @ripcurlx @pazza83