Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bitcoinj 0.15.8.bisq.13 (commit dcf8af0) #4962

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Use bitcoinj 0.15.8.bisq.13 (commit dcf8af0) #4962

merged 1 commit into from
Dec 16, 2020

Conversation

oscarguindzberg
Copy link
Contributor

Fixes #4870

@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 16, 2020
@oscarguindzberg
Copy link
Contributor Author

bitcoinj commits that were added:
bisq-network/bitcoinj@902679f
bisq-network/bitcoinj@1a786a2
bisq-network/bitcoinj@bc8d2e7

chimp1984
chimp1984 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I reviewed the BitcoinJ changes but I am not familiar with the details of the BloomFilter implementation.

@oscarguindzberg oscarguindzberg mentioned this pull request Dec 16, 2020
Closed
@ripcurlx ripcurlx merged commit c5c93b2 into bisq-network:release/v1.5.2 Dec 16, 2020
@chimp1984
Copy link
Contributor

@ripcurlx Can you cherry pick that to master as well?

@ripcurlx
Copy link
Contributor

@ripcurlx Can you cherry pick that to master as well?

I can create a PR for it - sure

@ripcurlx ripcurlx mentioned this pull request Dec 17, 2020
Closed
@ripcurlx
Copy link
Contributor

@ripcurlx Can you cherry pick that to master as well?

#4964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarguindzberg @chimp1984 @ripcurlx