Add option to hide non supported payment methods #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currencies as TransferWise supports sending to most currencies.
…of the users accounts. Default value is false, so same behaviour as before the change. If no payment account is setup then we also show all payment methods. In that case (no payment account) we disable the toggle as well as set it to false.
This was referenced Jan 2, 2021
sqrrm
approved these changes
Jan 4, 2021
|
Kind of confused what this changes exactly? Photo may help? The toggle already removes (hides) non supported payment methods?
|
Using that toggle hides all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option in preferences to hide payment methods from combobox in the Offer views which are not part of the users accounts.
Default value is false, so same behaviour as before that PR.
If no payment account is setup then we also show all payment methods.
In that case (no payment account) we disable the toggle as well as show it in false state.
Based on #5042
Starts at commit eddb7cb