Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CPU-intensive animations #5090

Merged
merged 2 commits into from Jan 19, 2021
Merged

Disable CPU-intensive animations #5090

merged 2 commits into from Jan 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2021

The CPU usage would skyrocket while the animated progress controls at DAO block processing or trade funding were on display. On certain Linux distributions (Qubes, gentoo) this would be crippling.

  • Comments out the code for footer bar progress indicator shown when receiving a DAO block
  • Comments out the code for the spinner indicator shown when waiting for trade to be funded

#4370 (comment)
#4649 (comment)

Fixes #4649
Fixes #4370

jmacxx added 2 commits January 18, 2021 13:23
Comments out the code for footer bar progress indicator shown when
receiving a DAO block

Comments out the code for the spinner indicator shown when waiting
for trade to be funded

#4649 (comment)

Fixes #4649
@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 19, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - It does look a little bit weird in some cases as if the UI is stuck, but hitting the fan in all those cases is also not an option on the long run. Would be great if we can fix this properly soon.

@ripcurlx ripcurlx merged commit 071e1e5 into bisq-network:master Jan 19, 2021
@ghost ghost mentioned this pull request Jan 24, 2021
@ghost ghost deleted the disable_cpu_intensive_animations branch May 29, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU consumption skyrockets on create offer / take offer High CPU Consumed
1 participant