Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup error: "You must have bootstrapped before adding data to the P2P network" #5191

Merged
merged 1 commit into from Feb 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2021

TriggerPriceService is changed to use a BootstrapListener on the P2PService so that it can start after the P2P network is ready.

Fixes #5190 : Prevents an Uncaught Exception error at startup.


To test (pre):

  1. Create offer Buy, choosing "Deactivate offer if over x" price with a trigger price just above current spot.
  2. Close down Bisq and wait for the market price to move over the deactivation price.
  3. Start Bisq, the error message above will pop up.

To test (post):

After applying this patch, at step 3 the offer will be deactivated successfully on startup and not produce an error popup.

TriggerPriceService is changed to use a BootstrapListener
on the P2PService so that it can start after the P2P network
is ready.

Fixes #5190 : Prevents an Uncaught Exception error at startup.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.6.0 milestone Feb 15, 2021
@ripcurlx ripcurlx merged commit 43ac2c9 into bisq-network:master Feb 15, 2021
@ghost ghost deleted the fix_TriggerPriceService_bootstrap branch May 29, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You must have bootstrapped before adding data to the P2P network
1 participant