Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file mentioned to from .desktop to .service #5319

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

wallclockbuilder
Copy link
Contributor

@wallclockbuilder wallclockbuilder commented Mar 16, 2021

Bisq Monitor does not include a .desktop in the monitor folder.
It does have a .service file which is spoken about in the lines that follow the mention.
I think this was a brain fart. Author meant to introduce .service file, mentioned .desktop instead.

Bisq Monitor does not include a `.desktop` in systemd. It does have a `.service` file which is spoken about in the lines that follow.
@wallclockbuilder wallclockbuilder force-pushed the patch-3 branch 2 times, most recently from e128edb to c0b9773 Compare March 19, 2021 09:13
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Please see my comment.

@@ -1,5 +1,6 @@
# Bisq Network Monitor Node


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this empty line? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 5b1da87 into bisq-network:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants