Remove the apparent link for cases where the trade is not available for mediators #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallclockbuilder
approved these changes
Mar 25, 2021
wallclockbuilder
suggested changes
Mar 26, 2021
desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java
Show resolved
Hide resolved
ripcurlx
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it appears now the TradeID column for mediators:
Before it appeared as an hyperlink that was not actually working.
Note that the trade is only known to the 2 people involved in the trade.
It is not shared with the Mediator/Arbitrator and for this reason a mediator is expected to not be able to pull trade details as it happens for the peers involved.
EDIT:
WAIT for the merge. Me and @jmacxx are investigating some display issues.
EDIT2:
Now it could be merged.