Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disputes UI improvements #5370

Merged
merged 3 commits into from Apr 13, 2021
Merged

Disputes UI improvements #5370

merged 3 commits into from Apr 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2021

Fixes #5367

  • Adds a border for dispute chat.
  • Window title displays "Dispute chat window for trade...."
  • Each chat message indicates who it is from, e.g. Received [timestamp] From Mediator

See screenshots.

Screenshot from 2021-03-28 15-05-01


Screenshot from 2021-03-28 15-04-24

Copy link
Contributor

@wallclockbuilder wallclockbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost
Copy link
Author

ghost commented Apr 1, 2021

@ripcurlx: I added 23535de to fix something for @refund-agent2; closes the chat window when its associated ticket is closed.

@ghost ghost mentioned this pull request Apr 2, 2021
@ghost
Copy link
Author

ghost commented Apr 7, 2021

Added a820959 per #5392

Support agents want the process & chat buttons on the left. For users it makes sense for the chat button to be on the right, consistent with how it is shown in TradeView. Hopefully that makes everyone happy! 😀

@ghost ghost changed the title Add a visual border indication for dispute chat window Disputes UI improvements Apr 7, 2021
@ripcurlx
Copy link
Contributor

@pedromvpg What do you think about the new blue border for distinguishing trader chat from dispute chat?

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Code changes are looking fine. If @pedromvpg comes up with some design changes I think we can do it in a follow-up PR.

@ripcurlx ripcurlx merged commit 64fe6c1 into bisq-network:master Apr 13, 2021
@ripcurlx ripcurlx added this to the v1.6.3 milestone Apr 13, 2021
@ghost ghost mentioned this pull request May 4, 2021
@ghost ghost deleted the mediation_follow_up_issues2 branch May 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 1.6.0 mediation style is confusing
2 participants