Fix shutdown persistence issue in Seednode #5388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue raised by @Emzy in Keybase ops. Seednode v1.6.0 was not persisting on shutdown.
#5280 introduced a guard in PersistenceManager to not persist at shutdown if a valid app start was not seen.
Initialize PersistenceManager in Seednode app so that the expected persist on shutdown can occur.
@chimp1984 plz check.
[edit] per @chimp1984 suggestion below, moved the init call to
AppSetupWithP2P.onBasicServicesInitialized