Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start payment screen reftext message & sizing fixes. #6241

Merged
merged 1 commit into from Jun 9, 2022
Merged

Start payment screen reftext message & sizing fixes. #6241

merged 1 commit into from Jun 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 8, 2022

Fixes #6238 "Payment started button not shown on small res screens"
Fixes #6212 "Add "LEAVE PAYMENT REASON BLANK" to payment details panel"

See screenshots for details.

For payment methods that show the reftext warning, it will be displayed together with the payment details and "Payment Started" button.

On machines where the actual vertical resolution is < 800 pixels, it will show a scroll bar for the make payment step, to prevent a situation where the start payment button was not able to be put into view.

Other changes to save vertical space are to limit the vertical size of address textareas somewhat as they are scrollable anyway.

image

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.2 milestone Jun 8, 2022
@ripcurlx ripcurlx merged commit 6fdd479 into bisq-network:master Jun 9, 2022
@w0000000t
Copy link
Contributor

w0000000t commented Jun 24, 2022

I was thinking more on the lines of having a field like the others for Amount, Account, Bank name, this one titled Payment reason, and inside LEAVE EMPTY!!!11ONE
But I suppose someone would end up writing just that in the payment reason 😅 so probably have the field empty under Payment reason, and under it, in small red characters (like when you try and use a Revolut routing number when creating faster payment account) it says "leave empty! or agree with peer in trader chat about a specific reason"

@w0000000t
Copy link
Contributor

In general, I feel that the way this warning is implemented, it's not relevant enough to a user, they wouldn't perceive how important it really is to leave the reason blank.

@ghost ghost mentioned this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment started button not shown on small res screens
2 participants