Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear sensitive data from trade ProcessModel #6283

Merged
merged 1 commit into from Jul 12, 2022
Merged

Clear sensitive data from trade ProcessModel #6283

merged 1 commit into from Jul 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2022

Fixes #6278

It turns out that the trade ProcessModel includes a copy of the peer's PaymentAccountPayload and contractAsJson. That was something missed from the earlier implementation. This PR extends the work done in #6001 to clear such data from the ProcessModel of the trade. There is no change in data visible via the GUI; this ProcessModel data is used during the trade execution only. Per user preferences defined via the previous PR, the data will be cleared for closed trades n days after the trade.

e.g.

Jul-06 12:29:14.920 [JavaFX Application Thread] INFO  b.c.a.BisqSetup: initDomainServices 
Jul-06 12:29:14.987 [JavaFX Application Thread] INFO  b.c.s.d.DisputeManager: ArbitrationManager checking closed disputes eligibility for having sensitive data cleared 
Jul-06 12:29:14.991 [JavaFX Application Thread] INFO  b.c.s.d.DisputeManager: MediationManager checking closed disputes eligibility for having sensitive data cleared 
Jul-06 12:29:14.995 [JavaFX Application Thread] INFO  b.c.s.d.DisputeManager: RefundManager checking closed disputes eligibility for having sensitive data cleared 
Jul-06 12:29:15.001 [JavaFX Application Thread] INFO  b.c.t.ClosedTradableManager: checking closed trades eligibility for having sensitive data cleared 
Jul-06 12:29:15.003 [JavaFX Application Thread] INFO  b.c.t.m.b.Trade: cleared sensitive data from processModel; of trade 00092328 
Jul-06 12:29:15.003 [JavaFX Application Thread] INFO  b.c.t.m.b.Trade: cleared sensitive data from processModel; of trade jaRXhK9 
Jul-06 12:29:15.004 [JavaFX Application Thread] INFO  b.c.t.m.b.Trade: cleared sensitive data from processModel; of trade 05198700 
Jul-06 12:29:15.005 [JavaFX Application Thread] INFO  b.c.t.m.b.Trade: cleared sensitive data from processModel; of trade 92647 

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.5 milestone Jul 12, 2022
@ripcurlx ripcurlx merged commit f0db452 into bisq-network:master Jul 12, 2022
@ghost ghost mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensitive data still visible in ClosedTrades file
1 participant