Clear sensitive data from trade ProcessModel #6283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6278
It turns out that the trade ProcessModel includes a copy of the peer's
PaymentAccountPayload
andcontractAsJson
. That was something missed from the earlier implementation. This PR extends the work done in #6001 to clear such data from the ProcessModel of the trade. There is no change in data visible via the GUI; this ProcessModel data is used during the trade execution only. Per user preferences defined via the previous PR, the data will be cleared for closed tradesn
days after the trade.e.g.