Send funds - don't use all available funds by default #6316
Conversation
| @@ -364,7 +364,7 @@ protected void activate() { | |||
| feeToggleGroup.selectToggle(feeIncludedRadioButton); | |||
|
|
|||
| if (inputsToggleGroup.getSelectedToggle() == null) | |||
| inputsToggleGroup.selectToggle(useAllInputsRadioButton); | |||
| inputsToggleGroup.selectToggle(useAllInputs.get() ? useAllInputsRadioButton : useCustomInputsRadioButton); | |||
There was a problem hiding this comment.
Legacy nit: current Bisq coding standards dictate use of curly braces for all conditional statements even one liners.
There was a problem hiding this comment.
I think it would be better to prepare all files fix in separated pull request. If you'd like I can do research regarding codacy configuration that would force developers to always use curly braces.
There was a problem hiding this comment.
I think it would be better to prepare all files fix in separated pull request. If you'd like I can do research regarding codacy configuration that would force developers to always use curly braces.
I fear that would be quite a big PR to review 😬 - I'll check why Codacy didn't catch this in their checks.
There was a problem hiding this comment.
AvoidInlineConditionals of Checkstyle doesn't seem to be triggered by this 🤔. I don't remember anymore exactly, but I thought the ? : conditionals are still ok to be used. No strong opinion from my side on this.
There was a problem hiding this comment.
I fear that would be quite a big PR to review
That's true. I think we can omit this for now and merge this pull request as it is.
Fixes #5866