Updating DAO->Governance menu to indicate vote possible

[ghost]

Fixes #3744

Replacing ChangeListener with EasyBind.Subscription causes immediate invoke change at the time of binding creation, which fixes posted issue

[ghost]

@xyzmaker123 while testing in Bisq prior to this PR I'm unable to recreate the problem.

• Start localnet cluster
• Create proposal to change parameter
• Advance blocks to blind vote
• See asymmetrical menus from the proposal creator and the voter

Both menu buttons immediately change to VOTE ON PROPOSALS when the block advances to the blind vote stage.
I'd like to recreate the issue in order to test the fix. Please advise.

Screenshot:

[ghost]

@jmacxx You need to be on another view during advancing blocks to blind vote and then switch to DAO->Governance.

[ghost]

ACK

Regtest Testing note: the DAO facade phase property stays as Blind vote for 1 block into the break period. But it seems minor and does not really cause any trouble except the button says vote on proposals for one extra block actually in the break period. Possibly a minor bug in the DAO.

[ripcurlx]

As this is touching the DAO code it is necessary to get a ACK from @ManfredKarrer as well prior merging.

[ghost]

@ripcurlx It doesn't touch any domain code - only simple switch from ChangeListener to EasyBind.Subscription on UI level.

[ripcurlx]

As this is touching the DAO code it is necessary to get a ACK from @ManfredKarrer as well prior merging.

Yes, I'm aware of that, but we had cases in the past where also UI code caused some issues, so this is just an extra safety net. I'll try to ping @ManfredKarrer for a review.

[ManfredKarrer]

utACK

[ripcurlx]

utACK - based on #6324 (review)