Handle HttpExceptions at block handler #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikJannsen
force-pushed
the
handle-rpc-errors-gracefully
branch
2 times, most recently
from
35d4d2c to
4648f31
Compare
|
Testing in progress.. |
…andler. It seems that a reorgs or if a new block arrives quickly after another, that bitcoind is not ready for a request and throws an RPC error, also the blockhandler throws that if the new block came too fast. We try to request again with increasing delays up to 1 min. If after 10 attempts its still failing we do a reorg and start parting again.
HenrikJannsen
force-pushed
the
handle-rpc-errors-gracefully
branch
from
4648f31 to
0b07c10
Compare
ghost
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Did a few rounds of testing / revision with @HenrikJannsen .
Seednodes have been stable past 5 days, will ACK now and keep an eye on it in the future.
ripcurlx
approved these changes
Dec 1, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.