Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delimiter used for combined fields copypaste. #6538

Merged
merged 1 commit into from Jan 31, 2023
Merged

Fix delimiter used for combined fields copypaste. #6538

merged 1 commit into from Jan 31, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2023

Fixes #6536

It was splitting the field contents on blank space, so if the bank name contained a space then part of the name was copied when instead the part after the delimiter '/' is required.

e.g. National Bank Australia / 1234567 was copying Bank Australia but should copy 1234567

@ghost ghost closed this Jan 29, 2023
@ghost ghost reopened this Jan 29, 2023
@ghost ghost closed this Jan 30, 2023
@ghost ghost reopened this Jan 30, 2023
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alejandrogarcia83 alejandrogarcia83 merged commit 3f518d1 into bisq-network:master Jan 31, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Jan 31, 2023
@Conza88
Copy link

Conza88 commented Apr 11, 2023

Dear god yes thank you

@Conza88
Copy link

Conza88 commented Apr 11, 2023

Nothing was copying for me btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

National bank transfer (BSB code not copying)
2 participants