Maker check DAO health when handling OfferAvailabilityRequest. #6546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some cases where the offer maker's DAO is out of sync, any OfferAvailabilityRequests result in a failed trade.
This PR adds a check of the DAO when handling OfferAvailabilityRequests, thus preventing unnecessary failed trades.
The maker will be shown a popup informing them to resync the DAO.
If their BTC chain is not synced, they will be shown an appropriate message.
Previously the maker was oblivious to being in a bad state.
Background info:
It was seen in production that a maker's out of sync DAO was only detected after the offer availability handshake, during trade INIT. Ideally the offer availability stage should detect early and prevent the failed trade.