Feat: delayed payout tx backup/recovery. #6589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
closed this
Draft
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of: bisq-network/proposals#381 (comment)
Since the proposal was approved and I'd spent time working on this, thought I'd publish the completed work. But due to some doubt about its usefulness, will keep it marked "Draft" while waiting for comments.
The idea is that a user is able to recover a DPT backup in the case of catastrophic disk failure. Upon restoring their Bisq wallet from seedphrase, the software run by the user is able to decrypt their DPT backup from a P2P network resource file.
There have been a few (5 maybe?) support cases where this feature would have been useful.
However I'm not sure if the marginal benefit makes this feature worthwhile. The main risk in backing up each DPT to a network file, is the file will grow over time. Even though successful trades remove the backups, there can be cases where they do not get cleaned out, such as abandoned trades where probably you want to keep the backup anyway. Or other failures such as bugs. There is no possibility for pruning except individually by each user/creator. For 1000 records (500 non-closed trades) using the latest DPT, the file size is around 1.8Mb. All those records consume RAM as is the case for the entire Bisq db.
Screenshots:
DPT backup file would be amongst the largest DB files: