Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSQ trade fee validation NACK if tx unconfirmed for a long time #6615

Merged
merged 1 commit into from Mar 27, 2023
Merged

BSQ trade fee validation NACK if tx unconfirmed for a long time #6615

merged 1 commit into from Mar 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2023

Fixes #6603

When a user's wallet is out of sync they may create offers where the fee tx will never be confirmed, and would cause a failed trade if offer is taken.

Maker fees paid in BSQ cannot be checked until the tx confirms and is in the DAO database:

  • If an offer is confirmed, check the BSQ fee as usual.
  • If an offer is unconfirmed for more than 8 hours assume there is a wallet problem and NACK the validation, which will prevent the offer from being taken.
  • If an offer confirms after 8 hours the validation will be able to check the fee.

Taker fees paid in BSQ are checked after the 1st confirmation.

@ripcurlx ripcurlx added this to the v1.9.10 milestone Mar 27, 2023
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 5317797 into bisq-network:master Mar 27, 2023
@ghost ghost mentioned this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant